linux-kernel - RE: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB86769DE0BA3D2D077B2EFF378CD39@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date:   Mon, 30 Jan 2023 02:02:15 +0000
From:   Hongxing Zhu <hongxing.zhu@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Peng Fan <peng.fan@....com>, "marex@...x.de" <marex@...x.de>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        "tharvey@...eworks.com" <tharvey@...eworks.com>,
        Frank Li <frank.li@....com>
CC:     "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 2023年1月20日 16:08
> To: Hongxing Zhu <hongxing.zhu@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; shawnguo@...nel.org; Peng Fan
> <peng.fan@....com>; marex@...x.de; Marcel Ziswiler
> <marcel.ziswiler@...adex.com>; tharvey@...eworks.com; Frank Li
> <frank.li@....com>
> Cc: lorenzo.pieralisi@....com; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH v6 1/6] arm64: dts: Add i.MX8MM PCIe EP support
> 
> On 20/01/2023 06:25, Richard Zhu wrote:
> > Add i.MX8MM PCIe EP support.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 24
> +++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index 31f4548f85cf..9662aeccdb3b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -1315,6 +1315,30 @@ pcie0: pcie@...00000 {
> >  			status = "disabled";
> >  		};
> >
> > +		pcie0_ep: pcie_ep@...00000 {
> 
> No underscores in node names.
Hi Krzystof:
Thanks for your review comments.
Sorry to reply late, since I'm taking the Spring Festival Vacation in the past days.
Got that. Would be changed later.
> 
> > +			compatible = "fsl,imx8mm-pcie-ep";
> 
> Did you test it with bindings? Does it pass without warnings?
> 
> 
It's my fault that I'm trying to let fsl,imx6q-pcie.yaml to cover the binding
DT-schema for the Endpoint modes.

One standalone fsl,imx6q-pcie-ep.yaml should be created as DT-schema for i.MX
PCIe Endpoint modes.

I would summit next version a moment later. Please help to review them.
Thanks in advanced.

Best Regards
Richard Zhu

> Best regards,
> Krzysztof