linux-kernel - RE: [PATCH v6 2/6] arm64: dts: Add i.MX8MM PCIe EP support on EVK board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB867684E4FD61EE706D8A8EDB8CD39@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date:   Mon, 30 Jan 2023 02:02:33 +0000
From:   Hongxing Zhu <hongxing.zhu@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Peng Fan <peng.fan@....com>, "marex@...x.de" <marex@...x.de>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        "tharvey@...eworks.com" <tharvey@...eworks.com>,
        Frank Li <frank.li@....com>
CC:     "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v6 2/6] arm64: dts: Add i.MX8MM PCIe EP support on EVK
 board

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 2023年1月20日 16:09
> To: Hongxing Zhu <hongxing.zhu@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; shawnguo@...nel.org; Peng Fan
> <peng.fan@....com>; marex@...x.de; Marcel Ziswiler
> <marcel.ziswiler@...adex.com>; tharvey@...eworks.com; Frank Li
> <frank.li@....com>
> Cc: lorenzo.pieralisi@....com; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH v6 2/6] arm64: dts: Add i.MX8MM PCIe EP support on EVK
> board
> 
> On 20/01/2023 06:25, Richard Zhu wrote:
> > Add i.MX8MM PCIe EP support on EVK board.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > index 0ce3005d578d..9d65b70939fa 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > @@ -371,6 +371,19 @@ &pcie0 {
> >  	status = "okay";
> >  };
> >
> > +&pcie0_ep{
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_pcie0>;
> > +	clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&pcie0_refclk>,
> > +		 <&clk IMX8MM_CLK_PCIE1_AUX>;
> > +	assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>,
> > +			  <&clk IMX8MM_CLK_PCIE1_CTRL>;
> > +	assigned-clock-rates = <10000000>, <250000000>;
> > +	assigned-clock-parents = <&clk IMX8MM_SYS_PLL2_50M>,
> > +				 <&clk IMX8MM_SYS_PLL2_250M>;
> > +	status = "disabled";
> 
> It's already disabled. What are you doing here? Having disabled node is useless,
> so entire patch should be dropped.
Okay, the 2/4/6 patches would be dropped. Thanks.

Best Regards
Richard Zhu
> 
> Best regards,
> Krzysztof