linux-kernel - Re: [PATCH] vfio: platform: ignore missing reset if disabled at module init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161272ef-eebc-7b86-1290-d0d77f887700@redhat.com>
Date:   Mon, 30 Jan 2023 10:53:32 +0100
From:   Eric Auger <eric.auger@...hat.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>,
        Tomasz Duszynski <tduszynski@...vell.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "open list:VFIO PLATFORM DRIVER" <kvm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Cc:     "jerinj@...vell.com" <jerinj@...vell.com>
Subject: Re: [PATCH] vfio: platform: ignore missing reset if disabled at
 module init

Hi,

On 1/30/23 10:05, Tian, Kevin wrote:
>> From: Tomasz Duszynski <tduszynski@...vell.com>
>> Sent: Thursday, January 26, 2023 12:11 AM
>> @@ -653,7 +653,8 @@ int vfio_platform_init_common(struct
>> vfio_platform_device *vdev)
>>  	if (ret && vdev->reset_required)
>>  		dev_err(dev, "No reset function found for device %s\n",
>>  			vdev->name);
>> -	return ret;
>> +
>> +	return vdev->reset_required ? ret : 0;
>>  }
>>  EXPORT_SYMBOL_GPL(vfio_platform_init_common);
> It reads slightly better to me as below:
>
> 	if (ret & vdev->reset_required) {
> 		dev_err(...);
> 		return ret;
> 	}
>
> 	return 0;
>
agreed.

Thanks

Eric