linux-kernel - RE: [PATCH] vfio: platform: ignore missing reset if disabled at module init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM4PR18MB43687D458F4EE8EEABBB3A24D2D39@DM4PR18MB4368.namprd18.prod.outlook.com>
Date:   Mon, 30 Jan 2023 12:31:11 +0000
From:   Tomasz Duszynski <tduszynski@...vell.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>,
        Eric Auger <eric.auger@...hat.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "open list:VFIO PLATFORM DRIVER" <kvm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
CC:     Jerin Jacob Kollanukkaran <jerinj@...vell.com>
Subject: RE: [PATCH] vfio: platform: ignore missing reset if disabled at
 module init

>-----Original Message-----
>From: Tian, Kevin <kevin.tian@...el.com>
>Sent: Monday, January 30, 2023 10:06 AM
>To: Tomasz Duszynski <tduszynski@...vell.com>; Eric Auger <eric.auger@...hat.com>; Alex Williamson
><alex.williamson@...hat.com>; Cornelia Huck <cohuck@...hat.com>; Jason Gunthorpe <jgg@...pe.ca>;
>open list:VFIO PLATFORM DRIVER <kvm@...r.kernel.org>; open list <linux-kernel@...r.kernel.org>
>Cc: Jerin Jacob Kollanukkaran <jerinj@...vell.com>
>Subject: [EXT] RE: [PATCH] vfio: platform: ignore missing reset if disabled at module init
>
>External Email
>
>----------------------------------------------------------------------
>> From: Tomasz Duszynski <tduszynski@...vell.com>
>> Sent: Thursday, January 26, 2023 12:11 AM @@ -653,7 +653,8 @@ int
>> vfio_platform_init_common(struct vfio_platform_device *vdev)
>>  	if (ret && vdev->reset_required)
>>  		dev_err(dev, "No reset function found for device %s\n",
>>  			vdev->name);
>> -	return ret;
>> +
>> +	return vdev->reset_required ? ret : 0;
>>  }
>>  EXPORT_SYMBOL_GPL(vfio_platform_init_common);
>
>It reads slightly better to me as below:
>
>	if (ret & vdev->reset_required) {
>		dev_err(...);
>		return ret;
>	}
>
>	return 0;

Sure no problem.