linux-kernel - Re: [PATCH] staging: pi433: modify bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9j4BI3/ybsaLCfw@kadam>
Date:   Tue, 31 Jan 2023 14:14:12 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Guru Mehar Rachaputi <gurumeharrachaputi@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: modify bit_rate from u16 to u32

On Tue, Jan 31, 2023 at 11:52:41AM +0100, Guru Mehar Rachaputi wrote:

> I would like to know, if it is mentioned in the TODO, why is it
> so?
> 

If it were as simple as just changing the type, they would have done
that instead of adding it to the TODO.  :P

But in fairness the TODO entry is sort of vague and useless.  It should
say that this configuration stuff needs to be moved to sysfs instead of
being done through an IOCTL.  The we would need to port the userspace
tools to use sysfs instead of the IOCTL.  Then we would delete the
IOCTL.

https://lore.kernel.org/all/20220118135902.GH1951@kadam/

If you want to send a patch to update the TODO then you can do that.

regards,
dan carpenter