[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230201111031.dqdketybw3pqpywx@SoMainline.org>
Date: Wed, 1 Feb 2023 12:10:31 +0100
From: Marijn Suijten <marijn.suijten@...ainline.org>
To: Kalyan Thota <quic_kalyant@...cinc.com>
Cc: dri-devel@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, robdclark@...omium.org,
dianders@...omium.org, swboyd@...omium.org,
quic_vpolimer@...cinc.com, dmitry.baryshkov@...aro.org,
quic_abhinavk@...cinc.com
Subject: Re: [v1 1/3] drm/msm/disp/dpu1: clear dspp reservations in rm release
On 2023-01-30 07:21:30, Kalyan Thota wrote:
> Clear dspp reservations from the global state during
> rm release
DSPP, and a period at the end of a sentence. Also noticing inconsistent
linebreaks across these patches, stick to 72 chars.
> Signed-off-by: Kalyan Thota <quic_kalyant@...cinc.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>
Should this be considered a fix to be backported, or is it harmless? If
so:
Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver")
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> index 73b3442..718ea0a 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> @@ -572,6 +572,8 @@ void dpu_rm_release(struct dpu_global_state *global_state,
> ARRAY_SIZE(global_state->ctl_to_enc_id), enc->base.id);
> _dpu_rm_clear_mapping(global_state->dsc_to_enc_id,
> ARRAY_SIZE(global_state->dsc_to_enc_id), enc->base.id);
> + _dpu_rm_clear_mapping(global_state->dspp_to_enc_id,
> + ARRAY_SIZE(global_state->dspp_to_enc_id), enc->base.id);
> }
>
> int dpu_rm_reserve(
> --
> 2.7.4
>
Powered by blists - more mailing lists