linux-kernel - Re: [PATCH v2] ALSA: pci: lx6464es: fix a debug loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878rhhy3pt.wl-tiwai@suse.de>
Date:   Wed, 01 Feb 2023 13:23:10 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Dan Carpenter <error27@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Maxime Ripard <mripard@...nel.org>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: pci: lx6464es: fix a debug loop

On Tue, 31 Jan 2023 11:02:13 +0100,
Dan Carpenter wrote:
> 
> This loop accidentally reuses the "i" iterator for both the inside and
> the outside loop.  The value of MAX_STREAM_BUFFER is 5.  I believe that
> chip->rmh.stat_len is in the 2-12 range.  If the value of .stat_len is
> 4 or more then it will loop exactly one time, but if it's less then it
> is a forever loop.
> 
> It looks like it was supposed to combined into one loop where
> conditions are checked.
> 
> Fixes: 8e6320064c33 ("ALSA: lx_core: Remove useless #if 0 .. #endif")
> Signed-off-by: Dan Carpenter <error27@...il.com>
> ---
> v2: In the first version I just deleted the outside loop but that was
> not the correct fix.  Combine the conditions instead.

Thanks, applied.


Takashi