linux-kernel - Re: [PATCH V4 4/9] i2c: xiic: Add wait for FIFO empty in send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9034/vvjBehZXF5@shikoro>
Date:   Fri, 3 Feb 2023 17:35:47 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@....com>
Cc:     michal.simek@...inx.com, michal.simek@....com,
        devicetree@...r.kernel.org, andrew@...n.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, git@....com, srinivas.goud@....com,
        shubhrajyoti.datta@....com, manion05gk@...il.com,
        Raviteja Narayanam <raviteja.narayanam@...inx.com>
Subject: Re: [PATCH V4 4/9] i2c: xiic: Add wait for FIFO empty in send_tx

On Thu, Feb 02, 2023 at 03:11:33PM +0530, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@...inx.com>
> 
> If the tx_half_empty interrupt comes first instead of tx_empty,
> STOP bit is generated even before all the bytes are transmitted
> out on the bus.
> STOP bit should be sent only after all the bytes in the FIFO are
> transmitted out of the FIFO. So wait until FIFO is empty before sending
> the STOP bit.
> 
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@...inx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@....com>
> Acked-by: Michal Simek <michal.simek@....com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)