linux-kernel - Re: [PATCH V4 5/9] i2c: xiic: Add smbus_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y904V8zdCKDFxtR3@shikoro>
Date:   Fri, 3 Feb 2023 17:37:43 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@....com>
Cc:     michal.simek@...inx.com, michal.simek@....com,
        devicetree@...r.kernel.org, andrew@...n.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, git@....com, srinivas.goud@....com,
        shubhrajyoti.datta@....com, manion05gk@...il.com,
        Raviteja Narayanam <raviteja.narayanam@...inx.com>
Subject: Re: [PATCH V4 5/9] i2c: xiic: Add smbus_block_read functionality

On Thu, Feb 02, 2023 at 03:11:34PM +0530, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@...inx.com>
> 
> smbus_block_read is added to xiic driver to read from few sensors
> which support this command. Since the number of bytes to read is not
> known prior to transfer, xiic standard mode is being used for low level
> control of IP.
> 
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@...inx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@....com>
> Acked-by: Michal Simek <michal.simek@....com>

Applied to for-next, thanks!

> -	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | I2C_FUNC_SMBUS_BLOCK_DATA;

Note: Since you implemented I2C_M_RECV_LEN anyhow, you get the emulated
I2C_FUNC_SMBUS_BLOCK_PROC_CALL basically for free, so you could also use
I2C_FUNC_SMBUS_EMUL_ALL here.

If you'd like this, please send an incremental patch.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)