linux-kernel - Re: [PATCH] ipmi: ipmb: Fix the MODULE_PARM_DESC associated to 'retry_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 5 Feb 2023 09:15:23 -0600
From:   Corey Minyard <minyard@....org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Andrew Manley <andrew.manley@...lingtech.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH] ipmi: ipmb: Fix the MODULE_PARM_DESC associated to
 'retry_time_ms'

On Sun, Feb 05, 2023 at 11:04:01AM +0100, Christophe JAILLET wrote:
> 'This should be 'retry_time_ms' instead of 'max_retries'.

Oops.  Applied to my next tree.

Thanks,

-corey

> 
> Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/char/ipmi/ipmi_ipmb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c
> index 7c1aee5e11b7..3f1c9f1573e7 100644
> --- a/drivers/char/ipmi/ipmi_ipmb.c
> +++ b/drivers/char/ipmi/ipmi_ipmb.c
> @@ -27,7 +27,7 @@ MODULE_PARM_DESC(bmcaddr, "Address to use for BMC.");
>  
>  static unsigned int retry_time_ms = 250;
>  module_param(retry_time_ms, uint, 0644);
> -MODULE_PARM_DESC(max_retries, "Timeout time between retries, in milliseconds.");
> +MODULE_PARM_DESC(retry_time_ms, "Timeout time between retries, in milliseconds.");
>  
>  static unsigned int max_retries = 1;
>  module_param(max_retries, uint, 0644);
> -- 
> 2.34.1
>