linux-kernel - Re: [PATCH 1/2] platform/x86: dell-ddv: Add hwmon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230206162303.GA195090@roeck-us.net>
Date:   Mon, 6 Feb 2023 08:23:03 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Armin Wolf <W_Armin@....de>, markgross@...nel.org,
        jdelvare@...e.com, platform-driver-x86@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: dell-ddv: Add hwmon support

On Mon, Feb 06, 2023 at 03:13:25PM +0100, Hans de Goede wrote:
> Hi Armin,
> 
> On 2/5/23 21:54, Armin Wolf wrote:
> > Thanks to bugreport 216655 on bugzilla triggered by the
> > dell-smm-hwmon driver, the contents of the sensor buffers
> > could be almost completely decoded.
> > Add an hwmon interface for exposing the fan and thermal
> > sensor values. Since the WMI interface can be quite slow
> > on some machines, the sensor buffers are cached for 1 second
> > to lessen the performance impact.
> > The debugfs interface remains in place to aid in reverse-engineering
> > of unknown sensor types and the thermal buffer.
> > 
> > Tested-by: Antonín Skala <skala.antonin@...il.com>
> > Tested-by: Gustavo Walbon <gustavowalbon@...il.com>
> > Signed-off-by: Armin Wolf <W_Armin@....de>
> 
> This looks nice and clean to me, thank you:
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> 
> I'm going to wait a bit with merging this to see if Guenter
> has any remarks. If there are no remarks by next Monday then
> I'll merge this for the 6.3 merge window.
> 

I don't have any further remarks. I won't send an Ack, though.
I noticed that the empty lines before return statements distract
me sufficiently enough that I am not sure about the actual code.

Guenter