linux-kernel - [PATCH 0/2] nvmem: brcm_nvram: use buffered nvram data for cell values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230206100502.20243-1-wdehoog@exalondelft.nl>
Date:   Mon,  6 Feb 2023 13:05:00 +0300
From:   Willem-Jan de Hoog <arinc9.unal@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Willem-Jan de Hoog <wdehoog@...londelft.nl>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Arınç ÜNAL <arinc.unal@...nc9.com>,
        Rafał Miłecki <rafal@...ecki.pl>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        erkin.bozoglu@...ont.com
Subject: [PATCH 0/2] nvmem: brcm_nvram: use buffered nvram data for cell values

Words from Willem-Jan de Hoog:

On OpenWrt 22.03.3, Asus RT-AC88U does not boot anymore:

  UBI: auto-attach mtd4
  ubi0: attaching mtd4
  ubi0 error: 0xc04f0b3c: PEB 0 contains corrupted VID header, and the
     data does not contain all 0xFF
  ubi0 error: 0xc04f0b4c: this may be a non-UBI PEB or a severe VID
     header corruption which requires manual inspection

The problem seems to be that brcm_nvram_read accesses its (mapped) io
memory. When doing so the correct data is read but after that the
mtd/ubi process fails to work.

The bcm47xx_nvram.c code has buffered the nvram data so the cells value
can be read from there.

Willem-Jan de Hoog (2):
  firmware: bcm47xx_nvram: allow to read from buffered nvram data
  nvmem: brcm_nvram: use bcm47xx buffered data

 drivers/firmware/broadcom/bcm47xx_nvram.c | 14 ++++++++++++++
 drivers/nvmem/brcm_nvram.c                |  8 ++++++++
 include/linux/bcm47xx_nvram.h             |  6 ++++++
 3 files changed, 28 insertions(+)