[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87v8kfdp7l.fsf@mpe.ellerman.id.au>
Date: Mon, 06 Feb 2023 22:10:22 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Josh Poimboeuf <jpoimboe@...nel.org>, linux-kernel@...r.kernel.org
Cc: jgross@...e.com, richard.henderson@...aro.org,
ink@...assic.park.msu.ru, mattst88@...il.com,
linux-alpha@...r.kernel.org, linux@...linux.org.uk,
linux-arm-kernel@...ts.infradead.org, catalin.marinas@....com,
will@...nel.org, guoren@...nel.org, linux-csky@...r.kernel.org,
linux-ia64@...r.kernel.org, chenhuacai@...nel.org,
kernel@...0n.name, loongarch@...ts.linux.dev, f.fainelli@...il.com,
bcm-kernel-feedback-list@...adcom.com, tsbogend@...ha.franken.de,
linux-mips@...r.kernel.org, jiaxun.yang@...goat.com,
npiggin@...il.com, christophe.leroy@...roup.eu,
linuxppc-dev@...ts.ozlabs.org, ysato@...rs.sourceforge.jp,
dalias@...c.org, linux-sh@...r.kernel.org, davem@...emloft.net,
sparclinux@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
hpa@...or.com, chris@...kel.net, jcmvbkbc@...il.com,
linux-xtensa@...ux-xtensa.org, peterz@...radead.org,
juri.lelli@...hat.com, vincent.guittot@...aro.org,
dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
paulmck@...nel.org
Subject: Re: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume()
__noreturn
Josh Poimboeuf <jpoimboe@...nel.org> writes:
> start_secondary_resume() doesn't return. Annotate it as such. By
> extension this also makes arch_cpu_idle_dead() noreturn.
Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ?
Seems like it would be good documentation, even if it's not required
once the generic prototype is __noreturn.
But not a show-stopper.
Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)
cheers
> diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h
> index f63505d74932..cfd42ca8765c 100644
> --- a/arch/powerpc/include/asm/smp.h
> +++ b/arch/powerpc/include/asm/smp.h
> @@ -66,7 +66,7 @@ void start_secondary(void *unused);
> extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us);
> extern int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us);
> extern void smp_send_debugger_break(void);
> -extern void start_secondary_resume(void);
> +extern void __noreturn start_secondary_resume(void);
> extern void smp_generic_give_timebase(void);
> extern void smp_generic_take_timebase(void);
>
> --
> 2.39.0
Powered by blists - more mailing lists