linux-kernel - Re: [Patch V2 2/4] tpm: tegra: Support SPI tpm wait state detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+D+SHT63awKdC4H@sirena.org.uk>
Date:   Mon, 6 Feb 2023 13:19:04 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     Krishna Yarlagadda <kyarlagadda@...dia.com>, robh+dt@...nel.org,
        peterhuewe@....de, jgg@...pe.ca, jarkko@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-spi@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, thierry.reding@...il.com,
        jonathanh@...dia.com, skomatineni@...dia.com, ldewangan@...dia.com
Subject: Re: [Patch V2 2/4] tpm: tegra: Support SPI tpm wait state detect

On Mon, Feb 06, 2023 at 12:02:56PM +0100, Paul Menzel wrote:
> Am 03.02.23 um 14:01 schrieb Krishna Yarlagadda:

> > +	/* If the SPI device has an IRQ then use that */
> > +	if (dev->irq > 0)
> > +		irq = dev->irq;
> > +	else
> > +		irq = -1;

> Use ternary operator?

>     irq = dev->irq > 0 ? dev->irq : -1;

No, please write the code using normal conditional instructions.  This
isn't the IOCCC and the ternery operator is rarely a legibility aid.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)