linux-kernel - Re: [PATCH v9] module: replace module_layout with module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7E141837-4629-445E-BB58-EC49475E36A9@fb.com>
Date:   Tue, 7 Feb 2023 22:15:41 +0000
From:   Song Liu <songliubraving@...a.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     Song Liu <songliubraving@...a.com>, Song Liu <song@...nel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>,
        Kernel Team <kernel-team@...a.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH v9] module: replace module_layout with module_memory



> On Feb 7, 2023, at 2:13 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> On Mon, Feb 06 2023 at 23:27, Song Liu wrote:
>>> On Feb 6, 2023, at 1:45 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
>>>> +static void free_mod_mem(struct module *mod)
>>>> +{
>>>> + /* free the memory in the right order to avoid use-after-free */
>>> 
>>> How do we end up with a UAF when the ordering is different?
>> 
>> IIUC, we need remove MOD_DATA at last, which hosts "mod".
> 
> Oh. Please add a comment to that effect.
> 

Oops, I sent v10 too fast. 

Thanks,
Song