linux-kernel - Re: block: sleeping in atomic warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <339bf113-3ac1-7e62-3cca-45bb8b53d291@huaweicloud.com>
Date:   Wed, 8 Feb 2023 11:15:24 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Jens Axboe <axboe@...nel.dk>, Dan Carpenter <error27@...il.com>,
        linux-block@...r.kernel.org
Cc:     Julia Lawall <julia.lawall@...ia.fr>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Hongchen Zhang <zhanghongchen@...ngson.cn>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Christian Brauner (Microsoft)" <brauner@...nel.org>,
        David Howells <dhowells@...hat.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        maobibo <maobibo@...ngson.cn>,
        Matthew Wilcox <willy@...radead.org>,
        Sedat Dilek <sedat.dilek@...il.com>,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: block: sleeping in atomic warnings

Hi,

在 2023/02/08 2:31, Jens Axboe 写道:

>> block/blk-wbt.c:843 wbt_init() warn: sleeping in atomic context
>> ioc_qos_write() <- disables preempt
>> -> wbt_enable_default()
>>     -> wbt_init()
> 
> Also definitely a bug.
> 

This won't happen currently, wbt_init() will be called while
initializing device, and later wbt_enable_devault() from iocost won't
call wbt_init().

However, we might support rq_qos destruction dynamically in the
future, I'll fix this warning.

Thanks,
Kuai