linux-kernel - Re: [PATCH 1/3] nolibc: Add statx() support to implement sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 08 Feb 2023 08:29:47 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Willy Tarreau" <w@....eu>,
        "chris.chenfeiyang" <chris.chenfeiyang@...il.com>
Cc:     "Paul E. McKenney" <paulmck@...nel.org>,
        "Feiyang Chen" <chenfeiyang@...ngson.cn>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "Jiaxun Yang" <jiaxun.yang@...goat.com>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] nolibc: Add statx() support to implement sys_stat()

On Wed, Feb 8, 2023, at 04:31, Willy Tarreau wrote:
> On Wed, Feb 08, 2023 at 10:09:48AM +0800, Feiyang Chen wrote:
>> On Tue, 7 Feb 2023 at 22:31, Arnd Bergmann <arnd@...db.de> wrote:
> (...)
>> > Given that all architectures implement statx the same way, I wonder
>> > if we can't just kill off the old function here and always use statx.
>> >
>> > That would also allow removing the architecture specific
>> > sys_stat_struct definitions in all arch-*.h files.
>> >
>> 
>> Hi, Arnd,
>> 
>> I'd really like to make all architectures use sys_statx() instead
>> of sys_stat(). I just fear we might get dragged into a long discussion.
>> Can I send a patch series to do this later?
>
> I generally agree with the Arnd's points overall and I'm fine with the
> rest of your series. On this specific point, I'm fine with your proposal,
> let's just start with sys_statx() only on this arch, please add a comment
> about this possibility in the commit message that brings statx(),
> indicating that other archs are likely to benefit from it as well, and
> let's see after this if we can migrate all archs to statx.

Ok, makes sense. Just change the description then to note that this
will also fix riscv32 (which has only statx) as well as arc, hexagon,
nios2 and openrisc (which have statx and stat64 but not stat or newstat).

   Arnd