linux-kernel - Re: [PATCH 02/10] staging: rtl8192e: Calculate definition of MSR_LINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38b6c1a63909a1ce207e26deaf212588a83dd0ff.camel@perches.com>
Date:   Wed, 08 Feb 2023 07:56:03 -0800
From:   Joe Perches <joe@...ches.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] staging: rtl8192e: Calculate definition of
 MSR_LINK_MASK

On Wed, 2023-02-08 at 13:31 +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 07, 2023 at 07:16:22PM +0100, Philipp Hortmann wrote:
> > Calculate definition of MSR_LINK_MASK ((1<<0)|(1<<1)) = 3. Equation is not
> > accepted by checkpatch because of missing spaces.
[]
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h
[]
> > @@ -170,7 +170,7 @@ enum _RTL8192PCI_HW {
> >  #define	BW_OPMODE_20MHZ			BIT2
> >  	IC_VERRSION		= 0x301,
> >  	MSR			= 0x303,
> > -#define MSR_LINK_MASK      ((1<<0)|(1<<1))
> > +#define MSR_LINK_MASK      3
> 
> This is a bit field, it should be:
> 	#define MSR_LINK_MASK	(BIT(1) | BIT(0))
> right?

Perhaps better as GENMASK(1, 0)