linux-kernel - Re: [PATCH] m68k: allow PM menu options for COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 09:09:42 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        linux-m68k@...ts.linux-m68k.org
Subject: Re: [PATCH] m68k: allow PM menu options for COMPILE_TEST

Hi Geert,

On 2/9/23 06:03, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> On Thu, Feb 9, 2023 at 2:06 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>> Allow PM options for COMPILE_TEST. This quietens a kconfig
>> warning.
>>
>> This is similar to a patch for Sparc32 that was suggested by
>> Arnd.
>>
>> WARNING: unmet direct dependencies detected for PM
>>   Depends on [n]: !MMU [=y]
>>   Selected by [y]:
>>   - SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> 
> Thanks for your patch!
> 
>> --- a/arch/m68k/Kconfig
>> +++ b/arch/m68k/Kconfig
>> @@ -126,7 +126,7 @@ menu "Kernel Features"
>>
>>  endmenu
>>
>> -if !MMU
>> +if !MMU || COMPILE_TEST
>>  menu "Power management options"
> 
> I think this is the wrong solution.
> All other selects of PM are done by architecture/platform-gating

Yes, which is where they should be.

> symbols, and none of them can be enabled for compile-testing.
> 
> So either SUN20I_PPU should depend on PM, or ARCH_SUNXI
> should select PM.

I'll do the first choice since I shouldn't be the one to make
a platform config change without knowing about the platform.

Thank you.
-- 
~Randy