linux-kernel - RE: [PATCH 1/1] EDAC/skx: Fix overflows on the DRAM row address mapping arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 17:30:02 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
CC:     Borislav Petkov <bp@...en8.de>, Aristeu Rozanski <aris@...hat.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Xu, Feng F" <feng.f.xu@...el.com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 1/1] EDAC/skx: Fix overflows on the DRAM row address
 mapping arrays

> Fixes: 98f2fc829e3b ("EDAC, skx_edac: Delete duplicated code")

Please explain this Fixes tag. Looking at that commit I see that the 
skx_close_row[] and skx_open_row[] arrays were moved from one
file to another in that commit. But neither had the "34" entry that
you are adding in this patch. They both stopped at "33".

> static u8 skx_close_row[] = {
> -	15, 16, 17, 18, 20, 21, 22, 28, 10, 11, 12, 13, 29, 30, 31, 32, 33
> +	15, 16, 17, 18, 20, 21, 22, 28, 10, 11, 12, 13, 29, 30, 31, 32, 33, 34
>  };
 
> static u8 skx_open_row[] = {
> -	14, 15, 16, 20, 28, 21, 22, 23, 24, 25, 26, 27, 29, 30, 31, 32, 33
> +	14, 15, 16, 20, 28, 21, 22, 23, 24, 25, 26, 27, 29, 30, 31, 32, 33, 34
>  };

-Tony