linux-kernel - RE: [PATCH 1/1] EDAC/skx: Fix overflows on the DRAM row address mapping arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB617933E74BB2D538C0426A9589DE9@SJ1PR11MB6179.namprd11.prod.outlook.com>
Date:   Fri, 10 Feb 2023 07:30:06 +0000
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To:     "Luck, Tony" <tony.luck@...el.com>
CC:     Borislav Petkov <bp@...en8.de>, Aristeu Rozanski <aris@...hat.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Xu, Feng F" <feng.f.xu@...el.com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 1/1] EDAC/skx: Fix overflows on the DRAM row address
 mapping arrays

> From: Luck, Tony <tony.luck@...el.com>
> Sent: Friday, February 10, 2023 1:30 AM
> To: Zhuo, Qiuxu <qiuxu.zhuo@...el.com>
> Cc: Borislav Petkov <bp@...en8.de>; Aristeu Rozanski <aris@...hat.com>;
> Mauro Carvalho Chehab <mchehab@...nel.org>; Xu, Feng F
> <feng.f.xu@...el.com>; linux-edac@...r.kernel.org; linux-
> kernel@...r.kernel.org; stable@...r.kernel.org
> Subject: RE: [PATCH 1/1] EDAC/skx: Fix overflows on the DRAM row address
> mapping arrays
> 
> > Fixes: 98f2fc829e3b ("EDAC, skx_edac: Delete duplicated code")
> 
> Please explain this Fixes tag. Looking at that commit I see that the
> skx_close_row[] and skx_open_row[] arrays were moved from one file to
> another in that commit. But neither had the "34" entry that you are adding in
> this patch. They both stopped at "33".

Hi Tony,

I thought the commit "98f2fc829e3b" was the first commit of the new file skx_base.c and then chose it as the Fixes tag for this patch. But as your concern, this Fixes tag made people confused due to no changes on the two arrays by the commit "98f2fc829e3b" [1]. 

Do you think the original commit "4ec656bdf43a" of the file skx_edac.c (though it was removed) is the right commit to be used as the Fixes tag for this patch?

      Fixes: 4ec656bdf43a ("EDAC, skx_edac: Add EDAC driver for Skylake")

If yes, I’ll replace the Fixes tag with the new Fixes tag above in v2. 
If no, any suggestions for me? 😊 Thanks!

[1] The commit “98f2fc829e3b” only moved the skx_close_row[] and skx_open_row[] arrays from skx_edac.c to skx_base.c but made no changes on them.

-Qiuxu


> > static u8 skx_close_row[] = {
> > -	15, 16, 17, 18, 20, 21, 22, 28, 10, 11, 12, 13, 29, 30, 31, 32, 33
> > +	15, 16, 17, 18, 20, 21, 22, 28, 10, 11, 12, 13, 29, 30, 31, 32, 33,
> > +34
> >  };
> 
> > static u8 skx_open_row[] = {
> > -	14, 15, 16, 20, 28, 21, 22, 23, 24, 25, 26, 27, 29, 30, 31, 32, 33
> > +	14, 15, 16, 20, 28, 21, 22, 23, 24, 25, 26, 27, 29, 30, 31, 32, 33,
> > +34
> >  };
> 
> -Tony