[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230209094330.12a94139@jacob-builder>
Date: Thu, 9 Feb 2023 09:43:30 -0800
From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
To: "Tian, Kevin" <kevin.tian@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
Lu Baolu <baolu.lu@...ux.intel.com>,
Joerg Roedel <joro@...tes.org>,
David Woodhouse <dwmw2@...radead.org>,
"Raj, Ashok" <ashok.raj@...el.com>,
"Liu, Yi L" <yi.l.liu@...el.com>,
"Ghorai, Sukumar" <sukumar.ghorai@...el.com>,
"stable@...r.kernel.org" <stable@...r.kernel.org>,
Robin Murphy <robin.murphy@....com>,
"Kumar, Sanjay K" <sanjay.k.kumar@...el.com>,
jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v2] iommu/vt-d: Avoid superfluous IOTLB tracking in lazy
mode
Hi Kevin,
On Thu, 9 Feb 2023 02:09:47 +0000, "Tian, Kevin" <kevin.tian@...el.com>
wrote:
> > From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> > Sent: Thursday, February 9, 2023 2:19 AM
> >
> > - iommu_iotlb_gather_add_page(domain, gather, iova, size);
> > + /*
> > + * We do not use page-selective IOTLB invalidation in flush
> > queue,
> > + * There is no need to track page and sync iotlb.
> > Domain-selective or
>
> "in flush queue, so there is ..."
>
> > + * PASID-selective validation are used in the flush queue.
>
> the last sentence can be removed. same meaning as the first one.
>
sounds good.
> > + */
> > + if (!iommu_iotlb_gather_queued(gather))
> > + iommu_iotlb_gather_add_page(domain, gather, iova,
> > size);
>
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
>
Thanks,
Jacob
Powered by blists - more mailing lists