linux-kernel - Re: [PATCH v2 01/10] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <167596458765.553111.2698863120254622830.robh@kernel.org>
Date:   Thu, 9 Feb 2023 11:43:08 -0600
From:   Rob Herring <robh@...nel.org>
To:     Yong Wu <yong.wu@...iatek.com>
Cc:     Tiffany Lin <tiffany.lin@...iatek.com>,
        linux-media@...r.kernel.org,
        kyrie wu <kyrie.wu@...iatek.corp-partner.google.com>,
        youlin.pei@...iatek.com, Matthias Brugger <matthias.bgg@...il.com>,
        Will Deacon <will@...nel.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        chengci.xu@...iatek.com, mingyuan.ma@...iatek.com,
        devicetree@...r.kernel.org, Joerg Roedel <joro@...tes.org>,
        linux-arm-kernel@...ts.infradead.org, anan.sun@...iatek.com,
        iommu@...ts.linux.dev, libo.kang@...iatek.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        yf.wang@...iatek.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        linux-mediatek@...ts.infradead.org, nfraprado@...labora.com,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
        Yunfei Dong <yunfei.dong@...iatek.com>
Subject: Re: [PATCH v2 01/10] dt-bindings: media: mediatek,vcodec: Remove
 dma-ranges property


On Wed, 08 Feb 2023 13:36:34 +0800, Yong Wu wrote:
> After commit f1ad5338a4d5 ("of: Fix "dma-ranges" handling for bus
> controllers"), the dma-ranges of the leaf node doesn't work. Remove
> it for vcodec here.
> 
> 1) For mediatek,vcodec-decoder.yaml and mediatek,vcodec-encoder.yaml,
> this property is in the leaf node, it is invalid as the above comment.
> 
> Currently there is only mt8195 VENC node has this property in upstream.
> Indeed, VENC is affected, but it is not a fatal issue. Originally it
> expects its iova range locate at 4GB-8GB. However after that commit, its
> expectation doesn't come true, it will fall back to 0-4GB iova and also
> could work well.
> 
> 2) For mediatek,vcodec-subdev-decoder.yaml, It already uses parent-child
> node, this property works. Instead, MediaTek iommu will control the
> masters' iova ranges by the master's larb/port id internally, then the
> dma-ranges property is unnecessary for the master's node.
> 
> Cc: Tiffany Lin <tiffany.lin@...iatek.com>
> Cc: Andrew-CT Chen <andrew-ct.chen@...iatek.com>
> Cc: Yunfei Dong <yunfei.dong@...iatek.com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-decoder.yaml | 5 -----
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 5 -----
>  .../bindings/media/mediatek,vcodec-subdev-decoder.yaml     | 7 -------
>  3 files changed, 17 deletions(-)
> 

Acked-by: Rob Herring <robh@...nel.org>