[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7f96a46c330459961e2fc18afd92fdfd66ab2bf5.camel@mediatek.com>
Date: Thu, 9 Feb 2023 06:48:09 +0000
From: Jian Yang (杨戬) <Jian.Yang@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>
CC: "linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Jieyy Yang (杨洁) <Jieyy.Yang@...iatek.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Chuanjia Liu (柳传嘉)
<Chuanjia.Liu@...iatek.com>,
Qizhong Cheng (程啟忠)
<Qizhong.Cheng@...iatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"kw@...ux.com" <kw@...ux.com>,
Jianjun Wang (王建军)
<Jianjun.Wang@...iatek.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"lpieralisi@...nel.org" <lpieralisi@...nel.org>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
Ryder Lee <Ryder.Lee@...iatek.com>,
David-YH Chiu (邱鈺翔)
<David-YH.Chiu@...iatek.com>,
Rex-BC Chen (陳柏辰)
<Rex-BC.Chen@...iatek.com>
Subject: Re: [PATCH 2/2] dt-bindings: PCI: mediatek-gen3: Add support for
controlling power and reset
Dear Rob,
Thanks for your comment.
On Fri, 2023-02-03 at 10:07 -0600, Rob Herring wrote:
> On Tue, Jan 10, 2023 at 9:28 PM Jian Yang <jian.yang@...iatek.com>
> wrote:
> >
> > From: "jian.yang" <jian.yang@...iatek.com>
> >
> > Add new properties to support control power supplies and reset pin
> > of
> > a downstream component.
> >
> > Signed-off-by: jian.yang <jian.yang@...iatek.com>
> > ---
> > .../bindings/pci/mediatek-pcie-gen3.yaml | 23
> > +++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 7e8c7a2a5f9b..46149cc63989 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -84,6 +84,29 @@ properties:
> > items:
> > enum: [ phy, mac ]
> >
> > + pcie1v8-supply:
> > + description:
> > + The regulator phandle that provides 1.8V power to downstream
> > component.
> > +
> > + pcie3v3-supply:
> > + description:
> > + The regulator phandle that provides 3.3V power to downstream
> > component.
> > +
> > + pcie12v-supply:
> > + description:
> > + The regulator phandle that provides 12V power to downstream
> > component.
>
> While in some bindings we've allowed these in the host bridge node,
> that is a mistake. These should be in the root port node. You
> probably
> don't have one in DT, so add one.
In Mediatek's PCIe structure, there is only one root port under a host
bridge. I am wondering if you think it's necessary to add a root port
node in our host bridge node based on that structure?
And I'm a bit confused about how to declare a property which should be
added in a root port node. I would be grateful if you could provide me
some good example about it.
> > +
> > + dsc-reset-gpios:
> > + description:
> > + The reset GPIO of a downstream component.
> > + maxItems: 1
> > +
> > + dsc-reset-msleep:
>
> Doesn't the PCI spec define this time? We're talking about PERST#,
> right?
The "dsc-reset-gpios" represents an extra reset pin other than PERST#
required by a downstream component. I tried to add a property here so
that users can control the delay time between the assertion and
deassertion according to their requirement, but Krzysztof mentioned
that there is an ongoing discussion about a "GPIO delay" driver can
handle this. So I will remove the "dsc-reset-msleep" in V2 patch.
> > + description:
> > + The delay time between assertion and de-assertion of a
> > downstream
> > + component's reset GPIO.
> > + maxItems: 1
> > +
> > clocks:
> > minItems: 4
> > maxItems: 6
> > --
> > 2.18.0
> >
Best regards,
Jian Yang
Powered by blists - more mailing lists