linux-kernel - Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  9 Feb 2023 14:30:02 +0100
From:   Michael Walle <michael@...le.cc>
To:     oliver.graute@...oconnector.com
Cc:     andrew@...n.ch, davem@...emloft.net, edumazet@...gle.com,
        hkallweit1@...il.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        netdev@...r.kernel.org, pabeni@...hat.com,
        simon.horman@...igine.com, Michael Walle <michael@...le.cc>
Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

> is this the right place to turn on the realtek phy LEDs for RTL8211F?

Probably not. There are a few issues. This will only work one particular
board. Therefore, you'd need some kind of runtime configuration to also
support other boards. But lately any LED related patches for PHYs were
NAK'd because they need to integrate with the LED subsystem. See [1].

-michael

[1] https://lore.kernel.org/r/YyxOTKJ8OTxXgWcA@lunn.ch/