linux-kernel - Re: [PATCH] PCI: Fix build error when CONFIG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af294def-fff7-469c-b8c6-a245ba641c2c@intel.com>
Date:   Fri, 10 Feb 2023 13:12:43 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     ALOK TIWARI <alok.a.tiwari@...cle.com>, <bhelgaas@...gle.com>,
        <nathan@...nel.org>, <ndesaulniers@...gle.com>, <trix@...hat.com>
CC:     <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <llvm@...ts.linux.dev>, <tglx@...utronix.de>,
        <kevin.tian@...el.com>, <darwi@...utronix.de>
Subject: Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled

Hi Alok,

On 2/10/2023 12:45 PM, ALOK TIWARI wrote:
> shall we need to define this function under -> #ifndef CONFIG_PCI_MSI
> 
> #ifndef CONFIG_PCI_MSI
> 
> +static inline struct msi_map
> +pci_msix_alloc_irq_at(struct pci_dev *dev, unsigned int index,
> +              const struct irq_affinity_desc *affdesc)
> +{
> +    struct msi_map map = { .index = -ENOSYS };
> +
> +    return map;
> +}
> +
> +static inline void pci_msix_free_irq(struct pci_dev *pdev, struct msi_map map)
> +{
> +}
> +#endif

No need. include/linux/pci.h already has those definitions.

include/linux/pci.h already has:

#ifdef CONFIG_PCI_MSI

...

#else

... 
/*  new function definitions will be inserted here */
...

#endif


Reinette