linux-kernel - Re: [PATCH AUTOSEL 6.1 18/38] powerpc/kvm: Fix unannotated intra-function call warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6349040-17ad-6066-0f8a-8adeb9c7b48d@linux.ibm.com>
Date:   Fri, 10 Feb 2023 16:56:31 +0530
From:   Sathvika Vasireddy <sv@...ux.ibm.com>
To:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        Michael Ellerman <mpe@...erman.id.au>, pbonzini@...hat.com,
        seanjc@...gle.com, npiggin@...il.com,
        linuxppc-dev@...ts.ozlabs.org,
        Sathvika Vasireddy <sv@...ux.ibm.com>
Subject: Re: [PATCH AUTOSEL 6.1 18/38] powerpc/kvm: Fix unannotated
 intra-function call warning

Hi Sasha,

On 09/02/23 16:44, Sasha Levin wrote:
> From: Sathvika Vasireddy <sv@...ux.ibm.com>
>
> [ Upstream commit fe6de81b610e5d0b9d2231acff2de74a35482e7d ]
>
> objtool throws the following warning:
>    arch/powerpc/kvm/booke.o: warning: objtool: kvmppc_fill_pt_regs+0x30:
>    unannotated intra-function call
>
> Fix the warning by setting the value of 'nip' using the _THIS_IP_ macro,
> without using an assembly bl/mflr sequence to save the instruction
> pointer.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Suggested-by: Michael Ellerman <mpe@...erman.id.au>
> Signed-off-by: Sathvika Vasireddy <sv@...ux.ibm.com>
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
> Link: https://lore.kernel.org/r/20230128124158.1066251-1-sv@linux.ibm.com
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>   arch/powerpc/kvm/booke.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
> index 7b4920e9fd263..3852209989f04 100644
> --- a/arch/powerpc/kvm/booke.c
> +++ b/arch/powerpc/kvm/booke.c
> @@ -912,16 +912,15 @@ static int kvmppc_handle_debug(struct kvm_vcpu *vcpu)
>   
>   static void kvmppc_fill_pt_regs(struct pt_regs *regs)
>   {
> -	ulong r1, ip, msr, lr;
> +	ulong r1, msr, lr;
>   
>   	asm("mr %0, 1" : "=r"(r1));
>   	asm("mflr %0" : "=r"(lr));
>   	asm("mfmsr %0" : "=r"(msr));
> -	asm("bl 1f; 1: mflr %0" : "=r"(ip));
>   
>   	memset(regs, 0, sizeof(*regs));
>   	regs->gpr[1] = r1;
> -	regs->nip = ip;
> +	regs->nip = _THIS_IP_;
>   	regs->msr = msr;
>   	regs->link = lr;
>   }

Please drop this patch because objtool enablement patches for powerpc 
are not a part of kernel v6.1


Thanks,
Sathvika