linux-kernel - Re: [PATCH AUTOSEL 6.1 17/38] powerpc/85xx: Fix unannotated intra-function call warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Feb 2023 19:06:36 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Sathvika Vasireddy <sv@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        christophe.leroy@...roup.eu, npiggin@...il.com,
        naveen.n.rao@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH AUTOSEL 6.1 17/38] powerpc/85xx: Fix unannotated
 intra-function call warning

On Fri, Feb 10, 2023 at 04:55:54PM +0530, Sathvika Vasireddy wrote:
>Hi Sasha,
>
>On 09/02/23 16:44, Sasha Levin wrote:
>>From: Sathvika Vasireddy <sv@...ux.ibm.com>
>>
>>[ Upstream commit 8afffce6aa3bddc940ac1909627ff1e772b6cbf1 ]
>>
>>objtool throws the following warning:
>>   arch/powerpc/kernel/head_85xx.o: warning: objtool: .head.text+0x1a6c:
>>   unannotated intra-function call
>>
>>Fix the warning by annotating KernelSPE symbol with SYM_FUNC_START_LOCAL
>>and SYM_FUNC_END macros.
>>
>>Reported-by: kernel test robot <lkp@...el.com>
>>Signed-off-by: Sathvika Vasireddy <sv@...ux.ibm.com>
>>Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>>Link: https://lore.kernel.org/r/20230128124138.1066176-1-sv@linux.ibm.com
>>Signed-off-by: Sasha Levin <sashal@...nel.org>
>>---
>>  arch/powerpc/kernel/head_85xx.S | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>diff --git a/arch/powerpc/kernel/head_85xx.S b/arch/powerpc/kernel/head_85xx.S
>>index 52c0ab416326a..d3939849f4550 100644
>>--- a/arch/powerpc/kernel/head_85xx.S
>>+++ b/arch/powerpc/kernel/head_85xx.S
>>@@ -862,7 +862,7 @@ _GLOBAL(load_up_spe)
>>   * SPE unavailable trap from kernel - print a message, but let
>>   * the task use SPE in the kernel until it returns to user mode.
>>   */
>>-KernelSPE:
>>+SYM_FUNC_START_LOCAL(KernelSPE)
>>  	lwz	r3,_MSR(r1)
>>  	oris	r3,r3,MSR_SPE@h
>>  	stw	r3,_MSR(r1)	/* enable use of SPE after return */
>>@@ -879,6 +879,7 @@ KernelSPE:
>>  #endif
>>  	.align	4,0
>>+SYM_FUNC_END(KernelSPE)
>>  #endif /* CONFIG_SPE */
>>  /*
>
>Please drop this patch because objtool enablement patches for powerpc 
>are not a part of kernel v6.1.

Ack, I'll drop this and the other one you've pointed out. Thanks!

-- 
Thanks,
Sasha