linux-kernel - Re: [PATCH V5 1/3] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b523fe7-ef94-bcaf-62b0-9e8503f592e4@linaro.org>
Date:   Fri, 10 Feb 2023 12:40:34 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@....com>,
        michal.simek@...inx.com, michal.simek@....com,
        devicetree@...r.kernel.org, andrew@...n.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     git@....com, srinivas.goud@....com, shubhrajyoti.datta@....com,
        manion05gk@...il.com,
        Raviteja Narayanam <raviteja.narayanam@...inx.com>
Subject: Re: [PATCH V5 1/3] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to
 compatible

On 09/02/2023 12:37, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@...inx.com>
> 
> Add xilinx I2C new version 'xlnx,axi-iic-2.1' string to compatible

A nit: Missing full stop in this sentence.

> Add clock-frequency as optional property.
> 
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@...inx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@....com>
> Acked-by: Michal Simek <michal.simek@....com>
> ---


>  
> +  clock-frequency:
> +    description:
> +      Optional I2C SCL clock frequency. If not specified, do not configure
> +      in software, rely only on hardware design value. Supported frequencies
> +      are 100KHz, 400KHz and 1MHz.
> +    default: 100000

Then also:
enum: [ 100000, 400000, 1000000 ]

and drop the freeform text (last sentence from description).

Best regards,
Krzysztof