linux-kernel - Re: [PATCH] dt-bindings: mmc: Add resets property to cadence SDHCI binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <07d2aad9-ce87-01d2-fb21-0301606231d3@linaro.org>
Date:   Fri, 10 Feb 2023 12:41:53 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: Add resets property to cadence SDHCI
 binding

On 09/02/2023 12:34, Kunihiko Hayashi wrote:
> Hi Krzysztof,
> 
> On 2023/02/09 18:14, Krzysztof Kozlowski wrote:
>> On 09/02/2023 02:42, Kunihiko Hayashi wrote:
>>> Cadence SDHCI controller allows reset control support on UniPhier SoC.
>>> Add resets property to cadence SDHCI binding.
>>>
>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
>>> ---
>>>   Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> index d3dce4d6c168..adacd0535c14 100644
>>> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> @@ -29,6 +29,9 @@ properties:
>>>     clocks:
>>>       maxItems: 1
>>>
>>> +  resets:
>>> +    maxItems: 1
>>
>> This looks specific to UniPhier, doesn't it?
> 
> I think this IP has some hardware reset lines, however,


Hm, fine with me. It's actually expected.

> it depends on the implementation whether the lines can be
> soft controlled or controlled by power-on-reset.
> 
> In case of UniPhier SoC, these lines are connected to the syscon
> reset controller, but deasserted with initial state.
> 
> Currently, the binding has one compatible.
> If drawing this dependency, Is the device dependent compatible necessary?
> Or I can remove reset property from DT.

No, its okay.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof