linux-kernel - Re: [PATCH] iio: frequency: adf4377: remove duplicate/repeating constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+fAa5N3YbMW6yJt@ubun2204.myguest.virtualbox.org>
Date:   Sat, 11 Feb 2023 21:50:59 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Saurabh Singh Sengar <ssengar@...rosoft.com>,
        Praveen Kumar <kumarpraveen@...ux.microsoft.com>,
        Deepak R Varma <drv@...lo.com>
Subject: Re: [PATCH] iio: frequency: adf4377: remove duplicate/repeating
 constant

On Sat, Feb 11, 2023 at 03:57:51PM +0100, Christophe JAILLET wrote:
> Le 11/02/2023 à 08:07, Deepak R Varma a écrit :
> > Constant ADF4377_0000_SOFT_RESET_R_MSK is unnecessarily or'ed with
> > itself. Remove the redundant constant from the expression.
> > Issue identified using doublebitand.cocci Coccinelle semantic patch.
> > 
> > Signed-off-by: Deepak R Varma <drv@...lo.com>
> > ---
> >   drivers/iio/frequency/adf4377.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf4377.c
> > index 26abecbd51e0..caefd7ea6b14 100644
> > --- a/drivers/iio/frequency/adf4377.c
> > +++ b/drivers/iio/frequency/adf4377.c
> > @@ -495,8 +495,8 @@ static int adf4377_soft_reset(struct adf4377_state *st)
> >   		return ret;
> >   	return regmap_read_poll_timeout(st->regmap, 0x0, read_val,
> > -					!(read_val & (ADF4377_0000_SOFT_RESET_R_MSK |
> > -					ADF4377_0000_SOFT_RESET_R_MSK)), 200, 200 * 100);
> > +					!(read_val & ADF4377_0000_SOFT_RESET_R_MSK),
> > +					200, 200 * 100);
> 
> Based on the code just above, it is likely that one is expected to be
> ADF4377_0000_SOFT_RESET_MSK.

Hello CJ,
I agree, that appears to be a close possibility. I also tried looking to the
data sheet, but could not conclude.
How can I make sure if the other one should be ADF4377_0000_SOFT_RESET_MSK?

Thank you,
./drv

> 
> CJ
> 
> >   }
> >   static int adf4377_get_freq(struct adf4377_state *st, u64 *freq)
>