linux-kernel - Re: copy on write for splice() from file to pipe?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+n95VtIG09MxZde@gondor.apana.org.au>
Date:   Mon, 13 Feb 2023 17:07:49 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     luto@...nel.org, david@...morbit.com, willy@...radead.org,
        metze@...ba.org, axboe@...nel.dk, linux-fsdevel@...r.kernel.org,
        linux-api@...r.kernel.org, io-uring@...r.kernel.org,
        linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
        samba-technical@...ts.samba.org
Subject: Re: copy on write for splice() from file to pipe?

Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
>  -     if (!(sk->sk_route_caps & NETIF_F_SG))
>  +     if (!(sk->sk_route_caps & NETIF_F_SG) ||
>  +         !(sk->sk_route_caps & (NETIF_F_HW_CSUM | NETIF_F_IP_CSUM)))
>                return sock_no_sendpage_locked(sk, page, offset, size, flags);

NETIF_F_SG depends on checksum offload so it should already be
calling sock_no_sendpage_locked if checksum offload is not
supported.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt