linux-kernel - Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cffa875-d8cc-a4fe-e18d-2e24c28a49d8@linaro.org>
Date:   Mon, 13 Feb 2023 11:45:23 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jianhua Lu <lujianhua000@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36523
 bindings

On 10/02/2023 17:19, Jianhua Lu wrote:
> Novatek NT36523 is a display driver IC that can drive DSI panel. It
> is also present in the csot and boe video mode panels. It is found
> in Xiaomi Mi Pad 5 series.
> 
> Signed-off-by: Jianhua Lu <lujianhua000@...il.com>
> ---
>  .../display/panel/novatek,nt36523.yaml        | 101 ++++++++++++++++++
>  1 file changed, 101 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> new file mode 100644
> index 000000000000..a7098d0ce7e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> @@ -0,0 +1,101 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek,nt36523.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT36523 based DSI display Panels
> +
> +maintainers:
> +  - Jianhua Lu <lujianhua000@...il.com>
> +
> +description: |
> +  The nt36523 IC from Novatek is a generic DSI Panel IC used to drive dsi
> +  panels.
> +  Right now, only support cost and boe LCD display panels with the

boe? both?

> +  resolution of 1600x2560. It is a video mode DSI panel.

The binding or hardware supports only 1600x2560? The how it can be
"right now"? It's defined, isn't it?

> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - xiaomi,elish-csot-nt36523
> +          - xiaomi,elish-boe-nt36523
> +      - const: novatek,nt36523
> +    description: This indicates the panel manufacturer of the panel that is
> +      in turn using the NT36523 panel driver. This compatible string
> +      determines how the NT36523 panel driver is configured for the indicated
> +      panel. The novatek,nt36523 compatible shall always be provided as a fallback.

Drop description. First it is free form text of binding, so unnecessary.
Second, does not really bring any new information.

> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: phandle of gpio for reset line - This should be 8mA, gpio
> +      can be configured using mux, pinctrl, pinctrl-names (active high)

Simplify description - 90% of it is redundant and only drive strength of
8 mA is important.

> +
> +  vddio-supply:
> +    description: regulator that supplies the I/O voltage
> +
> +  vddpos-supply:
> +    description: positive boost supply regulator
> +
> +  vddneg-supply:
> +    description: negative boost supply regulator
> +
> +  reg: true
> +  ports: true
> +  backlight: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vddio-supply
> +  - vddpos-supply
> +  - vddneg-supply
> +  - reset-gpios
> +  - ports
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |+

Drop +

> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi0 {

dsi {

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "xiaomi,elish-csot-nt36523", "novatek,nt36523";
> +            reg = <0>;
> +            vddio-supply = <&vreg_l14a_1p88>;
> +            vddpos-supply = <&lcd_vddpos_5p5>;
> +            vddneg-supply = <&lcd_vddneg_5p5>;
> +
> +            backlight = <&backlight>;
> +            reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> +
> +            ports {
> +              #address-cells = <1>;
> +              #size-cells = <0>;
> +
> +              port@0 {
> +                reg = <0>;

Mixed up indentation.

Best regards,
Krzysztof