linux-kernel - Re: [PATCH][next] nfsd: remove redundant assignment to pointer dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+ug53kWXe5tqZbw@kadam>
Date:   Tue, 14 Feb 2023 17:55:35 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Chuck Lever <chuck.lever@...cle.com>,
        Jeff Layton <jlayton@...nel.org>, linux-nfs@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] nfsd: remove redundant assignment to pointer dentry

On Tue, Feb 14, 2023 at 02:14:28PM +0000, Colin Ian King wrote:
> The pointer dentry is assigned a value that is never read, the
> assignment is redundant and can be removed.
> 
> Cleans up clang-scan warning:
> fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is
> never read [deadcode.DeadStores]
>         dentry = ERR_PTR(ret);
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

No need to initalized "int ret = -ENOMEM;" either.

regards,
dan carpenter