linux-kernel - Re: [PATCH][next] nfsd: remove redundant assignment to pointer dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 15:16:10 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Dan Carpenter <error27@...il.com>,
        Colin Ian King <colin.i.king@...il.com>
CC:     Jeff Layton <jlayton@...nel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] nfsd: remove redundant assignment to pointer dentry



> On Feb 14, 2023, at 9:55 AM, Dan Carpenter <error27@...il.com> wrote:
> 
> On Tue, Feb 14, 2023 at 02:14:28PM +0000, Colin Ian King wrote:
>> The pointer dentry is assigned a value that is never read, the
>> assignment is redundant and can be removed.
>> 
>> Cleans up clang-scan warning:
>> fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is
>> never read [deadcode.DeadStores]
>>        dentry = ERR_PTR(ret);
>> 
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> No need to initalized "int ret = -ENOMEM;" either.

Thanks for the report.

Both came in when I copied nfsd_mkdir. I'll clean them up.


--
Chuck Lever