linux-kernel - Re: [RFC PATCH] dt-bindings: dma: apple,sio: Add schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <6B75F1A1-E2DE-40D5-AA79-A764C65D8AD2@cutebit.org>
Date:   Tue, 14 Feb 2023 20:18:36 +0100
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Janne Grunau <j@...nau.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Hector Martin <marcan@...can.st>, devicetree@...r.kernel.org,
        Vinod Koul <vkoul@...nel.org>, Sven Peter <sven@...npeter.dev>,
        asahi@...ts.linux.dev, linux-kernel@...r.kernel.org,
        dmaengine@...r.kernel.org
Subject: Re: [RFC PATCH] dt-bindings: dma: apple,sio: Add schema


> On 14. 2. 2023, at 17:12, Rob Herring <robh@...nel.org> wrote:
> On Tue, 14 Feb 2023 15:10:53 +0100, Martin Povišer wrote:
>> Describe the SIO coprocessor which serves as pretend DMA controller on
>> recent Apple platforms.
>> 
>> Signed-off-by: Martin Povišer <povik+lin@...ebit.org>
>> ---
>> 
>> Since the schema mentions a loader preparing the binding appropriately,
>> here's a PR with the relevant (WIP) loader code, if anyone wants to look:
>> https://github.com/AsahiLinux/m1n1/pull/286
>> 
>> .../devicetree/bindings/dma/apple,sio.yaml    | 129 ++++++++++++++++++
>> 1 file changed, 129 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/dma/apple,sio.yaml
>> 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/dma/apple,sio.example.dts:24.35-27.11: Warning (node_name_vs_property_name): /example-0/interrupt-controller: node name and property name conflict

I saw the warning, but since I had copied that part of the example from
apple,admac.yaml I didn’t make much of it. Now that I look at it again,
the example in apple,admac doesn’t raise the same warning, how come?

This is just a curiosity since we don’t need the aic node in the example
anyway (unlike in apple,admac where it’s needed because of empty entries
in interrupts-extended).

Martin