linux-kernel - Re: [PATCH] staging: pi433: change (struct pi433_tx_cfg)->bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+tFf3dFR812iVbj@kadam>
Date:   Tue, 14 Feb 2023 11:25:35 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Jacob Bai <jacob.bai.au@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: change (struct pi433_tx_cfg)->bit_rate
 to be a u32

On Tue, Feb 14, 2023 at 05:33:46PM +1100, Jacob Bai wrote:
> Based on the TODO file and datasheet of pi433, the maximum bit rate for
> transmitter is 300kbps when modulation been set to FSK. Hence, the size
> should be u32 rather than u16.
> 
> Signed-off-by: Jacob Bai <jacob.bai.au@...il.com>
> ---

This breaks the user space API.

The TODO was updated recently to explain how to do this properly.

regards,
dan carpenter