linux-kernel - Re: [PATCH 1/2] tty: new helper function tty_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00390b00bf50f42ff112ee8e31b88c8d@dev.tdt.de>
Date:   Tue, 14 Feb 2023 10:17:56 +0100
From:   Florian Eckert <fe@....tdt.de>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     u.kleine-koenig@...gutronix.de, gregkh@...uxfoundation.org,
        pavel@....cz, lee@...nel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org, Eckert.Florian@...glemail.com
Subject: Re: [PATCH 1/2] tty: new helper function tty_get_mget



>> --- a/include/linux/tty.h
>> +++ b/include/linux/tty.h
>> @@ -419,8 +419,9 @@ void tty_unthrottle(struct tty_struct *tty);
>>   int tty_throttle_safe(struct tty_struct *tty);
>>   int tty_unthrottle_safe(struct tty_struct *tty);
>>   int tty_do_resize(struct tty_struct *tty, struct winsize *ws);
>> -int tty_get_icount(struct tty_struct *tty,
>> +int tty_get_icount(struct tty_struct *tty
> 
> The robot already complained about this ^^^.
> 
> Have you even tried to compile-test this?

Sorry I made a rebase of the patch set. My mistake!
I compiled and tested my changes against kernel 5.15 (OpenWrt).
And it worked as expected.

> 
>>   		struct serial_icounter_struct *icount);
>> +extern int tty_get_mget(struct tty_struct *tty);
>