[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+tn3Y+SraIetn5X@surfacebook>
Date: Tue, 14 Feb 2023 12:52:13 +0200
From: andy.shevchenko@...il.com
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] gpio: vf610: make irq_chip immutable
Tue, Feb 14, 2023 at 08:36:38AM +0100, Alexander Stein kirjoitti:
> Since recently, the kernel is nagging about mutable irq_chips:
>
> "not an immutable chip, please consider fixing it!"
>
> Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
> helper functions and call the appropriate gpiolib functions.
...
> The overall changes are based on commit f1138dacb7ff
> ("gpio: sch: make irq_chip immutable")
Nice, but you forgot one crucial detail. You need to mark GPIO resuested
whenever it's locked as IRQ and otherwise when unlocked.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists