[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdYHJOgO9K_H9QA1_VWgParbh+Xqh-oCmo3JAFtaMXYByg@mail.gmail.com>
Date: Wed, 15 Feb 2023 11:18:06 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: andy.shevchenko@...il.com
Cc: Alexander Stein <alexander.stein@...tq-group.com>,
Bartosz Golaszewski <brgl@...ev.pl>,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] gpio: vf610: make irq_chip immutable
On Tue, Feb 14, 2023 at 11:52 AM <andy.shevchenko@...il.com> wrote:
> Tue, Feb 14, 2023 at 08:36:38AM +0100, Alexander Stein kirjoitti:
> > Since recently, the kernel is nagging about mutable irq_chips:
> >
> > "not an immutable chip, please consider fixing it!"
> >
> > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
> > helper functions and call the appropriate gpiolib functions.
>
> ...
>
> > The overall changes are based on commit f1138dacb7ff
> > ("gpio: sch: make irq_chip immutable")
>
> Nice, but you forgot one crucial detail. You need to mark GPIO resuested
> whenever it's locked as IRQ and otherwise when unlocked.
+static const struct irq_chip vf610_irqchip = {
(...)
+ GPIOCHIP_IRQ_RESOURCE_HELPERS,
That's what this macro does ;)
Yours,
Linus Walleij
Powered by blists - more mailing lists