[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c16693a0-d28f-b83f-e2b9-6e4451b68d7c@linaro.org>
Date: Tue, 14 Feb 2023 12:06:07 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Janne Grunau <j@...nau.net>, Hector Martin <marcan@...can.st>,
Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Mark Kettenis <kettenis@...nbsd.org>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Marc Zyngier <maz@...nel.org>
Subject: Re: [PATCH v2 05/16] dt-bindings: interrupt-controller: apple,aic2:
Add apple,t8112-aic compatible
On 14/02/2023 12:03, Janne Grunau wrote:
> The Apple M2 SoC uses AICv2 and is compatible with the existing driver.
> Add its per-SoC compatible.
> Since multi-die versions of the M2 are not expected decrease
> '#interrupt-cells' to 3 for apple,t8112-aic. This is seamlessly handled
> inside the driver.
>
Thank you for your patch. There is something to discuss/improve.
>
> - The 2nd cell contains the die ID.
> + The 2nd cell contains the die ID (only present on apple,t6000-aic).
>
> The next cell contains the interrupt number.
> - HW IRQs: interrupt number
> @@ -110,6 +113,20 @@ additionalProperties: false
> allOf:
> - $ref: /schemas/interrupt-controller.yaml#
>
> +if:
This should be under "allOf" (as next entry so " - if:").
> + properties:
> + compatible:
> + contains:
> + const: apple,t8112-aic
> +then:
> + properties:
> + '#interrupt-cells':
> + const: 3
> +else:
> + properties:
> + '#interrupt-cells':
> + const: 4
> +
> examples:
> - |
> soc {
>
Best regards,
Krzysztof
Powered by blists - more mailing lists