[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a969510df240fda32a5b57099c8f90a6@dev.tdt.de>
Date: Tue, 14 Feb 2023 11:48:49 +0100
From: Florian Eckert <fe@....tdt.de>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, pavel@....cz,
lee@...nel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, Eckert.Florian@...glemail.com
Subject: Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes
Hello Uwe,
>>
>> TD/RD: Flash LED on data transmission (default)
>> CTS: DCE Ready to accept data from the DTE.
>> DSR: DCE is ready to receive and send data.
>> CAR: DCE is receiving a carrier from a remote DTE.
>> RNG: DCE has detected an incoming ring signal.
>>
>> The mode can be changed for example with the following command:
>> echo "CTS" /sys/class/leds/<led>/mode
>
> I wonder if the abstraction is better be done such that you can also
> configure the mode to trigger on (for example) TD and RNG. Then you'd
> need one property per signal and then something like the following
> would
> be possible:
>
> p=/sys/class/leds/<led>
> echo 1 > $p/tx
> echo 0 > $p/rx
> echo 1 > $p/rng
I thought about that before implementing this patch set, but then I
discarded it.
Coding several states would then become confusing for someone who look
at the LED.
I have now consciously decided that I want only display one state.
>
> Best regards
> Uwe
Powered by blists - more mailing lists