linux-kernel - Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 12:13:40 +0100
From:   Florian Eckert <fe@....tdt.de>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        Eckert.Florian@...glemail.com
Subject: Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes

Hello Jiri,

> 
>> +};
>> +
>> +static const char * const mode[] = {
> 

> This is not a wise name.

What do you suggest? For me, the 'mode' here was the most accurate.
It describes how the trigger should behave.

How about
* action
* switch
* tty_trigger


> 
>> +	[TTY_LED_CNT] = "TD/RD", // Trasmit Data / Receive Data
>> +	[TTY_LED_CTS] = "CTS", // CTS Clear To Send
>> +	[TTY_LED_DSR] = "DSR", // DSR Data Set Ready
>> +	[TTY_LED_CAR] = "CAR", // CAR Data Carrier Detect (DCD)
>> +	[TTY_LED_RNG] = "RNG", // RNG Ring Indicator (RI)
>>   };
>>     static void ledtrig_tty_restart(struct ledtrig_tty_data 
>> *trigger_data)
>> @@ -21,6 +38,74 @@ static void ledtrig_tty_restart(struct 
>> ledtrig_tty_data *trigger_data)
>>   	schedule_delayed_work(&trigger_data->dwork, 0);
>>   }

Best regards
-- Florian