linux-kernel - Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ece1fc9-f2e7-3567-9a16-3f950ee65709@kernel.org>
Date:   Thu, 16 Feb 2023 07:45:36 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Florian Eckert <fe@....tdt.de>
Cc:     linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        Eckert.Florian@...glemail.com
Subject: Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes

Hi,

On 14. 02. 23, 12:13, Florian Eckert wrote:
>>> +static const char * const mode[] = {
>>
> 
>> This is not a wise name.
> 
> What do you suggest? For me, the 'mode' here was the most accurate.
> It describes how the trigger should behave.

mode is fine but with a context. Like tty_led_mode.

thanks,
-- 
js