linux-kernel - Re: [PATCH v3 bpf] bpf, test_run: fix &xdp_frame misplacement for LIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <447ea90f-bd4c-6200-4c56-8eefec7050e2@intel.com>
Date:   Wed, 15 Feb 2023 19:11:20 +0100
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Martin KaFai Lau <martin.lau@...ux.dev>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Song Liu <song@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 bpf] bpf, test_run: fix &xdp_frame misplacement for
 LIVE_FRAMES

From: Martin Kafai Lau <martin.lau@...ux.dev>
Date: Wed, 15 Feb 2023 10:04:51 -0800

> On 2/15/23 7:21 AM, Alexander Lobakin wrote:
>>   /* The maximum permissible size is: PAGE_SIZE - sizeof(struct
>> xdp_page_head) -
>> - * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3368 bytes
>> + * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3408 bytes
>>    */
>> -#define MAX_PKT_SIZE 3368
>> +#define MAX_PKT_SIZE 3408
> 
> s390 has a different cache line size:
> 
> https://lore.kernel.org/all/20230128000650.1516334-11-iii@linux.ibm.com/
> 
> The above s390 fix is in bpf-next. It is better to target this patch for
> bpf-next also such that the CI can test it in s390.
> 

Oh, thanks for letting me know! Will do in a bit.

Thanks,
Olek