linux-kernel - RE: [PATCH v2 3/3] iommu: Remove ioasid infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276F0D583CE7365A088AFB28CA39@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Wed, 15 Feb 2023 03:27:12 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Jean-Philippe Brucker <jean-philippe@...aro.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        Jason Gunthorpe <jgg@...dia.com>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>,
        "Jean-Philippe Brucker" <jean-philippe@...aro.com>,
        Robin Murphy <robin.murphy@....com>,
        Will Deacon <will@...nel.org>,
        David Woodhouse <dwmw2@...radead.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "Liu, Yi L" <yi.l.liu@...el.com>
Subject: RE: [PATCH v2 3/3] iommu: Remove ioasid infrastructure

> From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Sent: Wednesday, February 15, 2023 1:05 AM
> 
> Hi Jean-Philippe,
> 
> On Tue, 14 Feb 2023 09:32:33 +0000, Jean-Philippe Brucker
> <jean-philippe@...aro.org> wrote:
> 
> > On Mon, Feb 13, 2023 at 10:44:14PM -0800, Jacob Pan wrote:
> > > +typedef unsigned int ioasid_t;
> > > +#ifdef CONFIG_IOMMU_SVA
> > > +static inline bool pasid_valid(ioasid_t ioasid)
> > > +{
> > > +	return ioasid != IOMMU_PASID_INVALID;
> > > +}
> > > +#endif
> >
> > This isn't specific to SVA, doesn't need an ifdef
> >
> until DMA API PASID support is in, this is SVA only? at least on x86?
> 

the name is pretty generic and it doesn't need SVA specific logic.