linux-kernel - Re: [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Feb 2023 11:34:40 +0800
From:   ChiYuan Huang <cy_huang@...htek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        ChiaEn Wu <chiaen_wu@...htek.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <peterwu.pub@...il.com>
Subject: Re: [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467
 compatible name

H, Krzysztof/Sebastian:
On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote:
> On 13/02/2023 21:53, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> >> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> >> "richtek,rt9467"
> >>
> >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> >> Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>
> >> ---
> > 
> > Is there a new version of this fixing the issues pointed out by Krzysztof?
> > Also I think the filename and $id should be changed to richtek,rt9467.yaml
> > in addition to the compatible change.
> 
> Yes, indeed.
> 
>From the current discussion, there're things to be fixed.
1. In bindings, change compatible property from 'richtek,rt9467-charger' to 'richtek,rt9467'.
2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml'

Anything else? like as changing source code filename from from 'rt9467-charger.c' to 'rt9467.c"?

And we'll submit a new patch to fix it days later.

Thanks.
> Best regards,
> Krzysztof
>