linux-kernel - Re: [PATCH] power: reset: odroid-go-ultra: fix I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e9cd799-48ee-51b8-f969-303690ca626a@linaro.org>
Date:   Wed, 15 Feb 2023 14:24:01 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>, Sebastian Reichel <sre@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Asmaa Mnebhi <asmaa@...dia.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: reset: odroid-go-ultra: fix I2C dependency

On 15/02/2023 13:47, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Since this driver can only be built-in, it fails to link when
> the I2C layer is in a loadable module:
> 
> x86_64-linux-ld: drivers/power/reset/odroid-go-ultra-poweroff.o: in function `odroid_go_ultra_poweroff_get_pmic_device':
> odroid-go-ultra-poweroff.c:(.text+0x30): undefined reference to `i2c_find_device_by_fwnode'
> 
> Tighten the dependency to only allow enabling
> POWER_RESET_ODROID_GO_ULTRA_POWEROFF is I2C is built-in as well.
> 
> Fixes: cec3b46b8bda ("power: reset: add Odroid Go Ultra poweroff driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the fix !

Acked-by: Neil Armstrong <neil.armstrong@...aro.org>

> ---
>   drivers/power/reset/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 7059bd1f2ee7..8c87eeda0fec 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -144,7 +144,7 @@ config POWER_RESET_OCELOT_RESET
>   config POWER_RESET_ODROID_GO_ULTRA_POWEROFF
>   	bool "Odroid Go Ultra power-off driver"
>   	depends on ARCH_MESON || COMPILE_TEST
> -	depends on I2C && OF
> +	depends on I2C=y && OF
>   	help
>   	  This driver supports Power off for Odroid Go Ultra device.
>