[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230216000529.fmdsgapwygxvmzsh@mercury.elektranox.org>
Date: Thu, 16 Feb 2023 01:05:29 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Arnd Bergmann <arnd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Asmaa Mnebhi <asmaa@...dia.com>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: reset: odroid-go-ultra: fix I2C dependency
Hi,
On Wed, Feb 15, 2023 at 02:24:01PM +0100, Neil Armstrong wrote:
> On 15/02/2023 13:47, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > Since this driver can only be built-in, it fails to link when
> > the I2C layer is in a loadable module:
> >
> > x86_64-linux-ld: drivers/power/reset/odroid-go-ultra-poweroff.o: in function `odroid_go_ultra_poweroff_get_pmic_device':
> > odroid-go-ultra-poweroff.c:(.text+0x30): undefined reference to `i2c_find_device_by_fwnode'
> >
> > Tighten the dependency to only allow enabling
> > POWER_RESET_ODROID_GO_ULTRA_POWEROFF is I2C is built-in as well.
> >
> > Fixes: cec3b46b8bda ("power: reset: add Odroid Go Ultra poweroff driver")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Thanks for the fix !
>
> Acked-by: Neil Armstrong <neil.armstrong@...aro.org>
Thanks, queued.
-- Sebastian
>
> > ---
> > drivers/power/reset/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index 7059bd1f2ee7..8c87eeda0fec 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> > @@ -144,7 +144,7 @@ config POWER_RESET_OCELOT_RESET
> > config POWER_RESET_ODROID_GO_ULTRA_POWEROFF
> > bool "Odroid Go Ultra power-off driver"
> > depends on ARCH_MESON || COMPILE_TEST
> > - depends on I2C && OF
> > + depends on I2C=y && OF
> > help
> > This driver supports Power off for Odroid Go Ultra device.
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists