linux-kernel - Re: [PATCH 3/3] rtc: mt6397: select IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <deefed32-f675-5f71-3eae-6ef3f07ed5f2@collabora.com>
Date:   Wed, 15 Feb 2023 15:29:49 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>,
        Eddie Huang <eddie.huang@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org, Marc Zyngier <maz@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Peter Rosin <peda@...ntia.se>
Subject: Re: [PATCH 3/3] rtc: mt6397: select IRQ_DOMAIN instead of depending
 on it

Il 13/02/23 05:15, Randy Dunlap ha scritto:
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
> it directly thru "make *config", so drivers should select it instead
> of depending on it if they need it.
> Relying on it being set for a dependency is risky.
> 
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
> 
> Therefore, change the use of "depends on" for IRQ_DOMAIN to
> "select" for RTC_DRV_MT6397.
> 
> Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Eddie Huang <eddie.huang@...iatek.com>
> Cc: Sean Wang <sean.wang@...iatek.com>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-mediatek@...ts.infradead.org
> Cc: Alessandro Zummo <a.zummo@...ertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: linux-rtc@...r.kernel.org
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Peter Rosin <peda@...ntia.se>
> ---
> I have a similar patch (should be a series) for REGMAP.
> 
>   drivers/rtc/Kconfig |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)